zzy/openssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

aesv8-armx.pl: Avoid buffer overrread in AES-XTS decryption

Browse Source 
Original author: Nevine Ebeid (Amazon)
Fixes: CVE-2023-1255

The buffer overread happens on decrypts of 4 mod 5 sizes.
Unless the memory just after the buffer is unmapped this is harmless.

Reviewed-by: Paul Dale <pauli@openssl.org>
Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
(Merged from https://github.com/openssl/openssl/pull/20759)
This commit is contained in:
Tomas Mraz 2023-04-17 16:51:20 +02:00
parent c8093347f7
commit 72dfe46550
3 changed files with 16 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
CHANGES.md
View File

@ -270,6 +270,15 @@ OpenSSL 3.1
### Changes between 3.1.0 and 3.1.1 [xx XXX xxxx] ### Changes between 3.1.0 and 3.1.1 [xx XXX xxxx]
* Fixed buffer overread in AES-XTS decryption on ARM 64 bit platforms which
happens if the buffer size is 4 mod 5. This can trigger a crash of an
application using AES-XTS decryption if the memory just after the buffer
being decrypted is not mapped.
Thanks to Anton Romanov (Amazon) for discovering the issue.
([CVE-2023-1255])
*Nevine Ebeid*
* Add FIPS provider configuration option to disallow the use of * Add FIPS provider configuration option to disallow the use of
truncated digests with Hash and HMAC DRBGs (q.v. FIPS 140-3 IG D.R.). truncated digests with Hash and HMAC DRBGs (q.v. FIPS 140-3 IG D.R.).
The option '-no_drbg_truncated_digests' can optionally be The option '-no_drbg_truncated_digests' can optionally be
@ -19943,6 +19952,7 @@ ndif
<!-- Links --> <!-- Links -->
[CVE-2023-1255]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-1255
[CVE-2023-0466]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0466 [CVE-2023-0466]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0466
[CVE-2023-0465]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0465 [CVE-2023-0465]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0465
[CVE-2023-0464]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0464 [CVE-2023-0464]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0464

3
NEWS.md
View File

@ -38,6 +38,8 @@ OpenSSL 3.1
### Major changes between OpenSSL 3.1.0 and OpenSSL 3.1.1 [under development] ### Major changes between OpenSSL 3.1.0 and OpenSSL 3.1.1 [under development]
* Fixed buffer overread in AES-XTS decryption on ARM 64 bit platforms
([CVE-2023-1255])
* Fixed documentation of X509_VERIFY_PARAM_add0_policy() ([CVE-2023-0466]) * Fixed documentation of X509_VERIFY_PARAM_add0_policy() ([CVE-2023-0466])
* Fixed handling of invalid certificate policies in leaf certificates * Fixed handling of invalid certificate policies in leaf certificates
([CVE-2023-0465]) ([CVE-2023-0465])
@ -1466,6 +1468,7 @@ OpenSSL 0.9.x
* Support for various new platforms * Support for various new platforms
<!-- Links --> <!-- Links -->
[CVE-2023-1255]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-1255
[CVE-2023-0466]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0466 [CVE-2023-0466]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0466
[CVE-2023-0465]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0465 [CVE-2023-0465]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0465
[CVE-2023-0464]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0464 [CVE-2023-0464]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-0464

4
crypto/aes/asm/aesv8-armx.pl
View File

@ -3367,7 +3367,7 @@ $code.=<<___ if ($flavour =~ /64/);
.align 4 .align 4
.Lxts_dec_tail4x: .Lxts_dec_tail4x:
add $inp,$inp,#16 add $inp,$inp,#16
vld1.32 {$dat0},[$inp],#16 tst $tailcnt,#0xf
veor $tmp1,$dat1,$tmp0 veor $tmp1,$dat1,$tmp0
vst1.8 {$tmp1},[$out],#16 vst1.8 {$tmp1},[$out],#16
veor $tmp2,$dat2,$tmp2 veor $tmp2,$dat2,$tmp2
@ -3376,6 +3376,8 @@ $code.=<<___ if ($flavour =~ /64/);
veor $tmp4,$dat4,$tmp4 veor $tmp4,$dat4,$tmp4
vst1.8 {$tmp3-$tmp4},[$out],#32 vst1.8 {$tmp3-$tmp4},[$out],#32
b.eq .Lxts_dec_abort
vld1.32 {$dat0},[$inp],#16
b .Lxts_done b .Lxts_done
.align 4 .align 4
.Lxts_outer_dec_tail: .Lxts_outer_dec_tail: