From 66325793ccd670c1ad8104666932bdb43cec6e42 Mon Sep 17 00:00:00 2001 From: Pauli Date: Mon, 22 Mar 2021 12:46:12 +1000 Subject: [PATCH] test: fix coverity 1451534: improper use of negative value Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/14638) --- test/servername_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/servername_test.c b/test/servername_test.c index ddf0417bc6..b417f8bcac 100644 --- a/test/servername_test.c +++ b/test/servername_test.c @@ -52,8 +52,8 @@ static int get_sni_from_client_hello(BIO *bio, char **sni) memset(&pkt4, 0, sizeof(pkt4)); memset(&pkt5, 0, sizeof(pkt5)); - len = BIO_get_mem_data(bio, (char **)&data); - if (!TEST_true(PACKET_buf_init(&pkt, data, len)) + if (!TEST_long_ge(len = BIO_get_mem_data(bio, (char **)&data), 0) + || !TEST_true(PACKET_buf_init(&pkt, data, len)) /* Skip the record header */ || !PACKET_forward(&pkt, SSL3_RT_HEADER_LENGTH) /* Skip the handshake message header */