From 4b29762802c05fa871f0e1efcf804e86db0ddaa2 Mon Sep 17 00:00:00 2001 From: Tomas Mraz Date: Tue, 25 Jul 2023 15:35:34 +0200 Subject: [PATCH] Add CHANGES.md and NEWS.md entries for CVE-2023-3817 Reviewed-by: Matt Caswell Reviewed-by: Paul Dale Reviewed-by: Tom Cosgrove Reviewed-by: Todd Short (Merged from https://github.com/openssl/openssl/pull/21550) --- CHANGES.md | 22 ++++++++++++++++++++-- NEWS.md | 2 ++ 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 28ed897231..07171d3ec1 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -286,7 +286,24 @@ OpenSSL 3.1 ### Changes between 3.1.1 and 3.1.2 [xx XXX xxxx] - * Fix DH_check() excessive time with over sized modulus + * Fix excessive time spent checking DH q parameter value. + + The function DH_check() performs various checks on DH parameters. After + fixing CVE-2023-3446 it was discovered that a large q parameter value can + also trigger an overly long computation during some of these checks. + A correct q value, if present, cannot be larger than the modulus p + parameter, thus it is unnecessary to perform these checks if q is larger + than p. + + If DH_check() is called with such q parameter value, + DH_CHECK_INVALID_Q_VALUE return flag is set and the computationally + intensive checks are skipped. + + ([CVE-2023-3817]) + + *Tomáš Mráz* + + * Fix DH_check() excessive time with over sized modulus. The function DH_check() performs various checks on DH parameters. One of those checks confirms that the modulus ("p" parameter) is not too large. @@ -323,7 +340,7 @@ OpenSSL 3.1 has to skip calls to `EVP_DecryptUpdate()` for empty associated data entries. - *Tomas Mraz* + *Tomáš Mráz* * When building with the `enable-fips` option and using the resulting FIPS provider, TLS 1.2 will, by default, mandate the use of an extended @@ -20050,6 +20067,7 @@ ndif +[CVE-2023-3817]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-3817 [CVE-2023-3446]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-3446 [CVE-2023-2975]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-2975 [RFC 2578 (STD 58), section 3.5]: https://datatracker.ietf.org/doc/html/rfc2578#section-3.5 diff --git a/NEWS.md b/NEWS.md index 899be2b616..2e47573b37 100644 --- a/NEWS.md +++ b/NEWS.md @@ -39,6 +39,7 @@ OpenSSL 3.1 ### Major changes between OpenSSL 3.1.1 and OpenSSL 3.1.2 [under development] + * Fix excessive time spent checking DH q parameter value ([CVE-2023-3817]) * Fix DH_check() excessive time with over sized modulus ([CVE-2023-3446]) * Do not ignore empty associated data entries with AES-SIV ([CVE-2023-2975]) * When building with the `enable-fips` option and using the resulting @@ -1481,6 +1482,7 @@ OpenSSL 0.9.x +[CVE-2023-3817]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-3817 [CVE-2023-3446]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-3446 [CVE-2023-2975]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-2975 [CVE-2023-2650]: https://www.openssl.org/news/vulnerabilities.html#CVE-2023-2650