zzy/openssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x_attrib: fix a memory leak

Browse Source 
The X509_NAME object needs to be free'd even if printing it fails.

Introduced in be5adfd6e3 ("Support subjectDirectoryAttributes and
associatedInformation exts", 2024-06-18), but subsequently moved in
7bcfb41489 ("ossl_print_attribute_value(): use a sequence value only if
type is a sequence", 2024-08-05).

Signed-off-by: Beat Bolli <dev@drbeat.li>

Reviewed-by: Tom Cosgrove <tom.cosgrove@arm.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25207)
This commit is contained in:
Beat Bolli 2024-08-15 12:35:02 +02:00 committed by Tomas Mraz
parent 1fb39522a2
commit 223e0020e4
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
crypto/x509/x_attrib.c
View File

@ -98,6 +98,7 @@ int ossl_print_attribute_value(BIO *out,
unsigned char *value;
X509_NAME *xn = NULL;
int64_t int_val;
int ret = 1;
switch (av->type) {
case V_ASN1_BOOLEAN:
@ -192,9 +193,9 @@ int ossl_print_attribute_value(BIO *out,
return 0;
}
if (X509_NAME_print_ex(out, xn, indent, XN_FLAG_SEP_CPLUS_SPC) <= 0)
return 0;
ret = 0;
X509_NAME_free(xn);
return 1;
return ret;
default:
break;