zzy/openssl
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

check-format-commit: call fewer unneeded processes

Browse Source 
`wc` does not output a file name if the input is stdin.

`awk` reads its file argument; there's no need for `cat`.

`sort -u` outputs unique lines. It should be supported on all platforms,
as it's specified by POSIX.

Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Neil Horman <nhorman@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/25562)
This commit is contained in:
Beat Bolli 2024-08-17 17:34:14 +02:00 committed by Tomas Mraz
parent 1c1223ff53
commit 0d6544cdf8
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
util/check-format-commit.sh
View File

@ -94,7 +94,7 @@ do
grep "$i " $TEMPDIR/ranges.txt >> $TEMPDIR/ranges.filter || true
done
cp $TEMPDIR/ranges.filter $TEMPDIR/ranges.txt
REMAINING_FILES=$(wc -l $TEMPDIR/ranges.filter | awk '{print $1}')
REMAINING_FILES=$(wc -l <$TEMPDIR/ranges.filter)
if [ $REMAINING_FILES -eq 0 ]
then
echo "This commit has no files that require checking"
@ -107,7 +107,7 @@ fi
# to $TEMPDIR/check-format. This give us the full file to run
# check-format.pl on with line numbers matching the ranges in the
# $TEMPDIR/ranges.txt file
for j in $(cat $TEMPDIR/ranges.txt | awk '{print $1}' | sort | uniq)
for j in $(awk '{print $1}' $TEMPDIR/ranges.txt | sort -u)
do
FDIR=$(dirname $j)
mkdir -p $TEMPDIR/check-format/$FDIR
@ -115,7 +115,7 @@ do
done
# Now for each file in $TEMPDIR/ranges.txt, run check-format.pl
for j in $(cat $TEMPDIR/ranges.txt | awk '{print $1}' | sort | uniq)
for j in $(awk '{print $1}' $TEMPDIR/ranges.txt | sort -u)
do
range_start=()
range_end=()