From 01fb4bff9bee4b6a652d42ec9f1b677773280450 Mon Sep 17 00:00:00 2001 From: Pauli Date: Tue, 29 Jun 2021 07:59:00 +1000 Subject: [PATCH] test: fix coverity 1469427 Improper use of negative value (NEGATIVE_RETURNS) Reviewed-by: Tomas Mraz (Merged from https://github.com/openssl/openssl/pull/15943) --- test/endecoder_legacy_test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/endecoder_legacy_test.c b/test/endecoder_legacy_test.c index 121e2de3d4..943cba56e5 100644 --- a/test/endecoder_legacy_test.c +++ b/test/endecoder_legacy_test.c @@ -289,7 +289,8 @@ static int test_membio_str_eq(BIO *bio_provided, BIO *bio_legacy) long len_provided = BIO_get_mem_data(bio_provided, &str_provided); long len_legacy = BIO_get_mem_data(bio_legacy, &str_legacy); - return TEST_long_ge(len_provided, 0) + return TEST_long_ge(len_legacy, 0) + && TEST_long_ge(len_provided, 0) && TEST_strn2_eq(str_provided, len_provided, str_legacy, len_legacy); }